vercel / nft

Node.js dependency tracing utility
https://npmjs.com/@vercel/nft
MIT License
1.31k stars 136 forks source link

fix: Add special case for Serial Port binary (.node) modules #415

Closed RogerHardiman closed 4 months ago

RogerHardiman commented 5 months ago

Tested with prebuilds and compiling serialport from source

styfle commented 5 months ago

Please add an integration test in ./test/integration to confirm this works as expected, thanks!

RogerHardiman commented 5 months ago

Good idea to add an integration test. I noticed another one of the binary .node special cases had an integration test.

RogerHardiman commented 5 months ago

Just a note to myself that currently one integration test fails with the error below before I add my new integration test

  ● should correctly trace and correctly execute sharp-pnpm.js

    Command failed: corepack enable && pnpm i

Test Suites: 1 failed, 3 passed, 4 total
Tests:       1 failed, 1368 passed, 1369 total
Snapshots:   0 total
Time:        530.549 s
Ran all test suites.
RogerHardiman commented 5 months ago

This has been updated with an integrating test. The test code (serialport.js) throws an exception if the .node modules are missing,

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 0.26.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: