search

vercel / og-image

Open Graph Image as a Service - generate cards for Twitter, Facebook, Slack, etc
https://og-image.vercel.app
MIT License
4.05k stars 1.27k forks source link

Would you consider allowing the first image to be custom ? #194

Closed bokub closed 1 year ago

bokub commented 2 years ago

Hi,

In this code, I see that you're not allowing the first image to be a custom URL.

https://github.com/vercel/og-image/blob/84e305d4946227ce8383988911f419db57c1cc3e/api/_lib/parser.ts#L61-L63

If I want to use a custom image, the easiest option for me is to:

I don't have a problem doing this, but it may be a painful process for some people, and I feel like it's a waste of resource because this project will probably be deployed dozens of times just to bypass this limitation.

So my question is: Would you consider allowing the first image to be custom ? Why did you forbid it it the first place?

Thanks!

styfle commented 2 years ago

Hi Boris,

This is expected and forking is the desired behavior.

This project is an example to show you how to build your own generator.

Every project should have a different background, different images, etc to match the brand of your website.

Ideally, we would make the deploy button one click so you don’t need to change config and we plan to do that in future, thanks!

Nithur-M commented 2 years ago

Does deploying my own version requires a pro plan? I get this error:Serverless Functions are limited to 1024 of memory (in steps of 64) for personal accounts (Hobby plan). To increase, create a team (Pro plan).

[edit]: Sorry, I forgot to remove the configs in vercel.json. Now it is working.