search

vercel / pkg

Package your Node.js project into an executable
https://npmjs.com/pkg
MIT License
24.33k stars 1.02k forks source link

chore: make corruption test pass on macos #1890

Closed Mikescops closed 1 year ago

Mikescops commented 1 year ago

In my last PR #1878, I left a test scenario as todo concerning damaging the binary.

In fact, damaging when the code is signed had no effect as we were likely damaging the file in a non sensitive place. To circumvent that I decided to skip the signature on macos (as other systems don't sign anyway), damage the file, then sign it manually and finally execute the test.

Mikescops commented 1 year ago

Outch, the auto-merge didn't wait for the macos test to pass...

robertsLando commented 1 year ago

@Mikescops I'm sorry for that, seems them are not set as required tests in order to pass, let's see if they end successfully

Mikescops commented 1 year ago

@robertsLando it went well thankfully

robertsLando commented 1 year ago

Perfect, thanks!