vercel / pkg

Package your Node.js project into an executable
https://npmjs.com/pkg
MIT License
24.33k stars 1.02k forks source link

Failed to compile node v18.5.0-win-x86 #1989

Closed kerwenzhang closed 11 months ago

kerwenzhang commented 1 year ago

What version of pkg are you using?

5.8.1

What version of Node.js are you using?

18.14.0

What operating system are you using?

Windows 10

What CPU architecture are you using?

x86_64

What Node versions, OSs and CPU architectures are you building for?

node 18.5.0-win-x86

Describe the Bug

I compiled pkg\examples\express using node.js v18.14.0 x86. The package.json was modified to:

{
  "name": "express-example",
  "license": "ISC",
  "bin": "index.js",
  "dependencies": {
    "express": "4.15.2"
  },
  "pkg": {
    "assets": [
      "views/**/*"
    ],
    "targets": [
      "node18-win-x86"
    ]
  }
}

When run pkg . it started to download and compile node 18.5.0-win-x86 image

But it stopped during compile image

Going to the node folder, I could run .\vcbuild.bat successfully.

Expected Behavior

Should compile sucessfully.

To Reproduce

Download pkg 5.8.1 Goto examples\express, run npm install modify package.json run pkg .

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

github-actions[bot] commented 11 months ago

This issue is now closed due to inactivity, you can of course reopen or reference this issue if you see fit.

matevy commented 11 months ago

This probably happens because you are building node 18.5.0 with gcc 13.