search

vercel / platforms

A full-stack Next.js app with multi-tenancy and custom domain support. Built with Next.js App Router and the Vercel Domains API.
https://app.vercel.pub
5.38k stars 689 forks source link

domain from page params converted to decodeURIComponent #313

Closed Adnan0061 closed 9 months ago

Adnan0061 commented 10 months ago

the issue here is that, from middleware this project rewrites the URL but in page params are string type. This creates a problem the domain becomes an encoded string.

so if the url has something like that it will break the site. more over why it's important if some put a value of NEXT_PUBLIC_ROOT_DOMAIN with similar content it will break. So this will be a better solution.

vercel[bot] commented 10 months ago

@Adnan0061 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

steven-tey commented 9 months ago

Oh good point, I ran into this bug myself on https://github.com/steven-tey/dub

Thank you so much 🙏