vercel / react-transition-progress

Show a progress bar while React Transitions run
https://react-transition-progress.vercel.app
MIT License
168 stars 17 forks source link

fix: bail out when clicking with `meta` or `ctrl` modifier keys #6

Closed carloitaben closed 6 months ago

carloitaben commented 6 months ago

The current implementation of the link component prevents the default behavior of opening a link in a new tab when doing cmd+click on Mac or ctrl+click on Windows. This PR restores this functionality.

timneutkens commented 6 months ago

I think we should copy https://github.com/vercel/next.js/blob/canary/packages/next/src/client/link.tsx#L180-L191 to match the behavior.

carloitaben commented 6 months ago

Makes sense! I've updated the PR. Let me know if there's anything else I can do 🙂

timneutkens commented 5 months ago

Published in 0.0.4! Thanks!