search

vercel / react-tweet

Embed tweets in your React application.
https://react-tweet.vercel.app
MIT License
1.49k stars 82 forks source link

fix: bump author spacing #106

Closed ctjlewis closed 11 months ago

ctjlewis commented 11 months ago

Use 0.5rem of spacing instead of 0.25rem. See comparison below.

0.5rem (proposed) 0.25rem (previous)
image image
lfades commented 11 months ago

It's better spacing but the current spacing matches the one in https://publish.twitter.com/?query=https%3A%2F%2Ftwitter.com%2Fvercel%2Fstatus%2F1683920951807971329&widget=Tweet.

ctjlewis commented 11 months ago

@lfades: That's apparently a styling bug Twitter left in that blockquote render. You can see that the spacing is only 4px compared to 12px in the normal UI:

Spacing Image
4px image
12px image

We can all see it's off, hell we could even make Twitter (or X, whatever) aware of it. The padding on the bottom of that row is 12px, in the Twitter UI it is 12px - the spacing should be twelve pixels.