vercel / speed-insights

Vercel Speed Insights package
https://vercel.com/docs/speed-insights
Apache License 2.0
57 stars 9 forks source link

Fix invalid exports by changing package type #16

Closed timolins closed 10 months ago

timolins commented 10 months ago

📓 What's in there?

Our build output didn't align with what's stated in the package.json. This change, makes the ESM file the default, and outputs ".cjs" for CommonJS. tsup docs for reference.

This also aligns with how it works in Web Analytics.

image
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speed-insights-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:31am
speed-insights-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:31am
speed-insights-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:31am
tobiaslins commented 10 months ago

We removed type: module before. Context:

feugy commented 10 months ago

Closing in favor of #17

Thanks for the work done!