vercel / speed-insights

Vercel Speed Insights package
https://vercel.com/docs/speed-insights
Apache License 2.0
57 stars 9 forks source link

Update `next/navigation` import & update license to use `apache 2.0` #23

Closed tobiaslins closed 10 months ago

tobiaslins commented 10 months ago

📓 What's in there?

linear[bot] commented 10 months ago
ALY-1099 Incorrect next/navigation import in @vercel/speed-insights

Salesforce case: [https://admin.vercel.com/cases/00175878](https://admin.vercel.com/cases/00175878) > We tried upgrading to the Speed Insights V2 product, currently in version 0.0.6. > > And we can't integrate it with our current ecosystem at least directly, when building (vercel build), this error comes up consistently: > > \- info Collecting page data ..Error \[ERR_MODULE_NOT_FOUND\]: Cannot find module '/Users/lautaro.urtiaga/Documents/dialpad/marketing-v2/node_modules/next/navigation' imported from /Users/lautaro.urtiaga/Documents/dialpad/marketing-v2/node_modules/vercel/speed-insights/dist/next/index.mjs > Did you mean to import next/navigation.js? > at new NodeError (node:internal/errors:399:5) > at finalizeResolution (node:internal/modules/esm/resolve:326:11) > at moduleResolve (node:internal/modules/esm/resolve:945:10) > at defaultResolve (node:internal/modules/esm/resolve:1153:11) > at nextResolve (node:internal/modules/esm/loader:163:28) > at ESMLoader.resolve (node:internal/modules/esm/loader:838:30) > at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18) > at ModuleWrap. (node:internal/modules/esm/module_job:77:40) > at link (node:internal/modules/esm/module_job:76:36) { > code: 'ERR_MODULE_NOT_FOUND' > } > > We were able to workaround this issue by patching directly the dependency with npm "patch package" dependency, to add the .js to the import in the end. That solved the problem. > > We are reach

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speed-insights-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:41am
speed-insights-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:41am
speed-insights-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:41am
speed-insights-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:41am
speed-insights-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:41am