vercel[bot]
commented
10 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| speed-insights-nextjs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 8, 2023 2:09pm |
| speed-insights-nuxt | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 8, 2023 2:09pm |
| speed-insights-remix | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 8, 2023 2:09pm |
| speed-insights-sveltekit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 8, 2023 2:09pm |
| speed-insights-vue | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 8, 2023 2:09pm |
📓 What's in there?
In a Sveltekit application, when importing
injectSpeedInsight()into a+layout.js/tsfile, the route could be undefined.🧪 How to test?
On the preview deployment, we can navigate between the 2 pages and see the metrics being collecting, and assigned to the correct route.
❗ Notes to reviewers
Please focus on
+layout.jsfile. I brought a simpler skeleton app instead of the full demo app which is irrelevant for us.This must be an edge case, because this
injectSpeedInsight()contains conditionals to only run on the client side, where therouteshould always be available. We can see the metrics correctly applied to the current route.