vercel[bot]
commented
5 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| speed-insights-astro | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
| speed-insights-nextjs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
| speed-insights-nuxt | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
| speed-insights-remix | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
| speed-insights-sveltekit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
| speed-insights-vue | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 12, 2024 10:51am |
📓 What's in there?
Fixes #32, #34
There's no strong reason for forcing users to provide a framework when they directly use
injectSpeedInsights(). This PR sets a default empty value.🧪 How to test?
Some new unit tests:
pnpm t❗ Notes to reviewers
I added very basic unit tests for this change, which will make it easier in the future for writing other, more valuable tests.
All tests are running in jsdom environment, except one, which uses node environment, to simulate server-side rendering. This forced me to adjust the
beforeEach()inpackages/web/jest.setup.ts.On my VSCode I'm getting many
Unsafe call of ananytyped value.eslint@typescript-eslint/no-unsafe-callerrors in test files, which we don't see when runningpnpm -F @vercel/speed-insights lintIs it the same for you @tobiaslins? I updated a couple types, but it didn't solved it.