search

vercel / style-guide

Vercel's engineering style guide
Mozilla Public License 2.0
1.18k stars 29 forks source link

Error when linting after upgrade to v6 #107

Open neil-sola opened 1 month ago

neil-sola commented 1 month ago

pnpm lint results in:

workflow-api:lint: Oops! Something went wrong! :(
workflow-api:lint: 
workflow-api:lint: ESLint: 8.57.0
workflow-api:lint: 
workflow-api:lint: TypeError: Cannot destructure property 'parent' of 'node' as it is undefined.
workflow-api:lint: Occurred while linting /Users/neil/sola/monorepo/serverless/workflow-api/src/v1/delete-workflow.ts:1
workflow-api:lint: Rule: "unused-imports/no-unused-imports"
workflow-api:lint:     at exports.unusedImportsPredicate (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint-plugin-unused-imports@3.1.0_eslint@8.57.0/node_modules/eslint-plugin-unused-imports/lib/rules/predicates.js:28:13)
workflow-api:lint:     at Object.value [as report] (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint-rule-composer@0.3.0/node_modules/eslint-rule-composer/lib/rule-composer.js:144:25)
workflow-api:lint:     at Program:exit (/Users/neil/sola/monorepo/node_modules/.pnpm/@typescript-eslint+eslint-plugin@7.10.0_@typescript-eslint+parser@7.10.0_eslint@8.57.0_typescript@5.3.3/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-unused-vars.js:301:33)
workflow-api:lint:     at ruleErrorHandler (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/linter.js:1076:28)
workflow-api:lint:     at /Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/safe-emitter.js:45:58
workflow-api:lint:     at Array.forEach (<anonymous>)
workflow-api:lint:     at Object.emit (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
workflow-api:lint:     at NodeEventGenerator.applySelector (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
workflow-api:lint:     at NodeEventGenerator.applySelectors (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
workflow-api:lint:     at NodeEventGenerator.leaveNode (/Users/neil/sola/monorepo/node_modules/.pnpm/eslint@8.57.0/node_modules/eslint/lib/linter/node-event-generator.js:349:14)
maufarinelli commented 3 weeks ago

My two cents here. I just had the same error and I found that it comes from eslint-plugin-unused-imports node_modules/eslint-plugin-unused-imports/lib/rules/predicates.js line 27

put a console log just after 

    const { node } = problem;
    console.log('problem', problem);

And you will see what is causing the issue for you.

I think unused-imports plugin has changed and is missing something.

SoumayaBessifi commented 2 weeks ago

Hi, unfortunately i'm facing the same issue and didn't find a fix yet