vercel / style-guide

Vercel's engineering style guide
Mozilla Public License 2.0
1.25k stars 33 forks source link

Enforce consistent enum usage #34

Closed mrmckeb closed 2 years ago

mrmckeb commented 2 years ago

We see people setting enum keys in const-style sometimes, but would prefer to standardise around the approach used in docs.

This can be set via: https://typescript-eslint.io/rules/naming-convention

Incorrect

enum Colors {
  RED = 'rgb(255, 0, 0)',
  NOT_RED = 'rgb(0, 255, 255)',
}

enum COLORS { /* ... */ }

Correct

enum Colors {
  Red = 'rgb(255, 0, 0)',
  NotRed = 'rgb(0, 255, 255)',
}

See:

vercel-release-bot commented 2 years ago

:tada: This issue has been resolved in version 4.0.0-canary.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vercel-release-bot commented 2 years ago

:tada: This issue has been resolved in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: