search

vercel / style-guide

Vercel's engineering style guide
Mozilla Public License 2.0
1.23k stars 33 forks source link

Inline recommended configs #40

Open mrmckeb opened 1 year ago

mrmckeb commented 1 year ago

As of the latest release, we've unpinned version dependencies.

This gives users more flexibility, and makes it easier to bump dependencies of this package (like @typescript-eslint) to support new TypeScript versions, etc.

This also introduces the risk of a plugin releasing a change to a recommended config in a minor release, which would be breaking as code that previously passed may now fail. Worse, a rule could be broken/removed in a minor release, breaking the config. We feel these risks are very low, which is why we opted to shelve this work for future.

mrmckeb commented 1 year ago

This would ideally be automated.

mrmckeb commented 1 year ago

We've started doing this, starting with the playwright-test config.

mrmckeb commented 6 months ago

This is probably more urgent now as more typescript-eslint seems to be shipping changes to these configs in minor updates, example: https://github.com/typescript-eslint/typescript-eslint/pull/8011