search

vercel / style-guide

Vercel's engineering style guide
Mozilla Public License 2.0
1.25k stars 33 forks source link

Prefer inline type imports #54

Closed dglsparsons closed 1 year ago

dglsparsons commented 1 year ago

https://github.com/import-js/eslint-plugin-import/issues/2469

Would much prefer 

import { type Foo } from 'some/package`

over 

import type { Foo } from 'some/package`

as it keeps the single import line, and all related entries together.

https://github.com/import-js/eslint-plugin-import/pull/2475 looks like it may block this though.

mrmckeb commented 1 year ago

Thanks @dglsparsons! We're waiting for the next release to enable this - but it's definitely on our list.

Closing as a duplicate of this: https://github.com/vercel/style-guide/issues/38

dglsparsons commented 1 year ago

Oh, good spot. I checked to see if it existed already. Must have somehow missed the other issue 🤦