search

vercel / style-guide

Vercel's engineering style guide
Mozilla Public License 2.0
1.25k stars 33 forks source link

Update typescript and typescript-eslint related dependencies #66

Closed joulev closed 1 year ago

joulev commented 1 year ago

TypeScript 5.1 has been out for a while now but @vercel/style-guide is still at peer dependency typescript@^4.8.0, causing warnings during installation:

 WARN  Issues with peer dependencies found
.
└─┬ @vercel/style-guide 4.0.2
  └── ✕ unmet peer typescript@^4.8.0: found 5.1.6

The @typescript-eslint/typescript-estree version used with @vercel/style-guide also doesn't support TypeScript 5.1

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.0.0

YOUR TYPESCRIPT VERSION: 5.1.6

Please only submit bug reports when using the officially supported version.

=============

I think it's time to release a new version with updated dependency and peer-dependency versions.

matt-pawley commented 1 year ago

👍 prettier version 3 is also now available and suffers the same problem.

mrmckeb commented 1 year ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on: