fix(typescript): `es2023` is not valid

vercel / style-guide

Vercel's engineering style guide

Mozilla Public License 2.0

1.25k stars 33 forks source link

fix(typescript): `es2023` is not valid #84

Closed mwskwong closed 7 months ago

mwskwong commented 9 months ago

According to

es2023 is not a valid value for lib and target. I propose using esnext for now (which is equivalent to es2023 in a sense) and keep monitoring the status, since once es2023 is available, esnext is likely equivalent to es2024 by that time.

Ethan-Arrowood commented 8 months ago

mwskwong commented 8 months ago

@Ethan-Arrowood Updated accordingly. However, I noticed https://github.com/tsconfig/bases/blob/main/bases/node20.json suggests the target for Node 20 should also be es2022. See whether you wish to have that aligned as well.

Ethan-Arrowood commented 8 months ago

Oh good point. Yeah I guess so. I think something is off with the timing (Node18 specifically) and it confused me. Thanks for contributing this!

mrmckeb commented 7 months ago

Thanks for the PR @mwskwong, and for the review @Ethan-Arrowood!

vercel-release-bot commented 7 months ago

:tada: This PR is included in version 5.2.0-canary.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vercel-release-bot commented 7 months ago

:tada: This PR is included in version 5.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: