vercel / turborepo

Build system optimized for JavaScript and TypeScript, written in Rust
https://turbo.build/repo/docs
MIT License
26.37k stars 1.84k forks source link

mac binaries are not signed by a valid apple dev account #6935

Open wyvern8 opened 10 months ago

wyvern8 commented 10 months ago

Verify canary release

Link to code that reproduces this issue

x

What package manager are you using / does the bug impact?

npm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

x

Describe the Bug

The binaries used by Turbo are not signed by Apple dev account correctly, and so Google Santa binary validation policies that only allows valid signers can mean that large organisations are limited to using hash whitelists which is not sustainable. https://github.com/google/santa cli https://santa.dev/binaries/santactl.html#fileinfo

Expected Behavior

santactl fileinfo turbo should not return Yes instead of Yes, but ad-hoc

To Reproduce

santactl fileinfo turbo should not return Yes instead of Yes, but ad-hoc

Additional context

No response

TURBO-2009

NicholasLYang commented 10 months ago

Hi @wyvern8, thanks for the issue. We're in the middle of simplifying our release process now that the Rust port is completed. Once we've accomplished that, we can look into signing binaries with a proper Apple developer account

Rohin-Chopra commented 7 months ago

Hey @NicholasLYang and @mehulkar , just following up on this issue, has there been any movement on this?