search

vercel / vercel-azure-devops-extension

An Azure DevOps Extension for deploying to Vercel from Azure Pipelines
MIT License
23 stars 5 forks source link

Remove trailing dash `-` from aliasingBranchName #18

Closed aldosch closed 8 months ago

aldosch commented 8 months ago

Dash removal logic was broken due to how the position of the dash was referenced.

❌ if (aliasingBranchName[branchNameExtendedLength] === '-') {
✅ if (aliasingBranchName.endsWith('-')) {

View in context

Related to: Truncate branchName (if necessary) to meet RFC 1035 criteria #17

🙇 Thank you for reporting and for your patience @RobertoArmas