search

verdaccio / monorepo

🏰 Core dependencies and plugins for verdaccio 5.x branch ⚠️ DEPRECATED
https://verdaccio.org
MIT License
81 stars 62 forks source link

proxy support for aws-s3-storage #712

Closed kongdewen closed 4 months ago

kongdewen commented 4 months ago

Is your feature request related to a problem? Please describe. in our setup, verdaccio cannot connect to the internet directly. we need to support proxy option on s3 request.

Describe the solution you'd like aws-sdk supports to pass the proxy option to the httpOptions setting of your config object as stated in https://github.com/aws/aws-sdk-js/blob/589d3b570e8cbf24976b7ce4606952be3363e2a0/doc-src/guide/Examples.md#using-proxies.

we would like to setup an option to pass the proxy to the s3 client as in https://github.com/verdaccio/monorepo/blob/main/plugins/aws-s3-storage/src/s3PackageManager.ts#L44.

Describe alternatives you've considered adopt the proxy setting from Environment variable if presents

kongdewen commented 4 months ago

Discussing ongoing in https://github.com/orgs/verdaccio/discussions/4607#discussion-6582459.