feat: add proxy support for s3 storage - Githubissues

verdaccio / monorepo

🏰 Core dependencies and plugins for verdaccio 5.x branch ⚠️ DEPRECATED

https://verdaccio.org

MIT License

81 stars 62 forks source link

feat: add proxy support for s3 storage #713

Closed kongdewen closed 3 months ago

kongdewen commented 3 months ago

Type: feature Scope: aws-s3-storage

The following has been addressed in the PR:

There is a related issue? As we discussed in https://github.com/orgs/verdaccio/discussions/4607#discussion-6582459.
Unit or Functional tests are included in the PR On my test station:

Verdaccio config

backends:
  aws-s3-storage:
    bucket: dev-us-east-1
    s3ForcePathStyle: true
    accessKeyId: xxx
    secretAccessKey: xxx
    region: us-east-1
    proxy: http://proxy:8080

restart verdaccio
down package successfully

verify from proxy log

1714579033.547    439 xxxx.xxxx.xxxx.xxxx TCP_MISS/200 115975 GET https://s3.amazonaws.com/dev-us-east-1/package/package-version.tgz - HIER_DIRECT/52.216.215.32 application/octet-stream

Description: If you cannot connect to the internet directly, you can pass a proxy config to use of HTTP or HTTPS proxies

juanpicado commented 3 months ago

@kongdewen I think you misunderstood what I meant, I mean https://github.com/verdaccio/monorepo/blob/main/CONTRIBUTING.md#commit-guidelines , would you mind restore the dependencies update in your last commit?