search

verdan / flaskoidc

A wrapper of Flask with pre-configured OIDC support
Apache License 2.0
52 stars 35 forks source link

Fixing url_for() attribute for scheme #18

Closed cccs-eric closed 2 years ago

cccs-eric commented 2 years ago

There was a "typo" in the previous PR. Wasn't really a typo since it was schema all over the place, but the important piece is the attribute in url_for() is _scheme and not _schema. When using _schema, it becomes an extra parameter in the URL returned, which has no effect on the URL scheme (HTTP vs HTTPS). I have reflected that fix also in the documentation as well as in the env variables.

verdan commented 2 years ago

@Danucas FYI

Danucas commented 2 years ago

Thanks @cccs-eric!! I think I need a grammar improvement 😅