Porting to Drupal

[GoogleCodeExporter]

We've built a Drupal module using this library and so far it's been working 
great. http://drupal.org/project/google_store_locator

However, we're finding that adding feature requests using the 
store-locator.compiled.js file is difficult since the file has been minified.

We tried using the 7 other js files included (e.g. store.js, panel.js), but 
Drupal requires that js files using jQuery include the wrapper...

(function($){})(jQuery)  

in order to avoid other js libraries name colliding with '$'. The problem is 
that none of the other js files include this wrapper (but the compiled one 
does). 

Would there be any chance of including those wrappers in the other js files, 
and/or providing a way of decompiling the store-locator.compiled.js? Thanks!

Original issue reported on code.google.com by michf...@gmail.com on 3 Oct 2012 at 9:11

[GoogleCodeExporter]

Hi Mike,

I'll include the compile script - it is just using the Closure compiler with 
the wrapper option.

Chris

Original comment by cbro@google.com on 20 Feb 2013 at 2:47

• Changed state: Accepted

[GoogleCodeExporter]

Great! Thanks again Chris.

Original comment by mike.fue...@commerceguys.com on 20 Feb 2013 at 9:57

[GoogleCodeExporter]

am i turning blind, or is there no compile script available yet?

Original comment by w...@coworks.be on 13 Mar 2013 at 5:19

[GoogleCodeExporter]

You're not going blind. It hasn't been added yet.

Original comment by mike.fue...@commerceguys.com on 15 Mar 2013 at 2:30

[GoogleCodeExporter]

Sorry, I ran into some issues. Our internal version of the compiler is 
different to the public version, and some fields aren't being exported. I'm 
working on it.

Original comment by cbro@google.com on 15 Mar 2013 at 10:22

[GoogleCodeExporter]

Glad to hear i'm not turning blind. Looking forward to it, thanks!

Original comment by w...@coworks.be on 21 Mar 2013 at 1:56

[GoogleCodeExporter]

Yeah i'de love to see this too :)

Original comment by dgtlm...@gmail.com on 10 Jul 2013 at 8:09

[GoogleCodeExporter]

I tried to compile with

java -jar compiler.jar --js *.js --js_output_file my-compiled.js

however it doesnt gel well with Drupal and the existing JS calls say the method 
is unavailable (also the filesize is way different, so I guess your compiler is 
different)

Original comment by dgtlm...@gmail.com on 10 Jul 2013 at 8:18

[GoogleCodeExporter]

I also need to recompile this. How do we do it?

Original comment by l...@umn.edu on 14 Aug 2013 at 7:39

[GoogleCodeExporter]

I like this project and would like to make it more generic (multi-language, 
more configuartion options) but I also don't seem to get it fully compiled. Can 
you please include the compile script?

Original comment by ajj.kla...@gmail.com on 19 Jan 2014 at 12:50

[GoogleCodeExporter]

I decided not to wait for an answer, tried a few things and managed to get it 
working using a specific order of the javascript files and NOT using the 
ADVANCED_OPTIMIZATIONS option:

java -jar compiler.jar --js js\common.js --js js\view.js --js js\panel.js --js 
js\store.js --js js\feature.js --js js\featureset.js --js js\gme-datasource.js 
--js js\static-datasource.js --js_output_file store-locator.min.js

Original comment by ajj.kla...@gmail.com on 20 Jan 2014 at 8:36

[GoogleCodeExporter]

Is there some news about compiler?

Original comment by karo...@gmail.com on 1 Apr 2014 at 8:27

[GoogleCodeExporter]

The project is now on GitHub, and includes a compile script:
https://github.com/googlemaps/js-store-locator

Original comment by cbro@google.com on 4 Nov 2014 at 11:17

• Changed state: Obsolete