verdict-project / verdict

Interactive-Speed Analytics: 200x Faster, 200x Fewer Cluster Resources, Approximate Query Processing
http://verdictdb.org
Apache License 2.0
248 stars 66 forks source link

Joezhong fix presto tpch select query #309

Closed Beastjoe closed 5 years ago

Beastjoe commented 5 years ago

Change the query to presto syntax. I also find the aggregate datatype returned from Presto is String. So, I add a static method to convert it.

pyongjoo commented 5 years ago

Thanks! Regarding the type conversion, is ours the expected behavior (at least to you)?

Beastjoe commented 5 years ago

Yes. Only resultset from Presto needs to be converted. The datatypes of Verdictdb seem to be all right.

codecov-io commented 5 years ago

Codecov Report

Merging #309 into yongjoo-count-distinct will decrease coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           yongjoo-count-distinct     #309      +/-   ##
==========================================================
- Coverage                   70.26%   70.05%   -0.21%     
==========================================================
  Files                         166      166              
  Lines                       10895    10895              
  Branches                     1781     1781              
==========================================================
- Hits                         7654     7631      -23     
- Misses                       2786     2810      +24     
+ Partials                      455      454       -1
Impacted Files Coverage Δ
...rg/verdictdb/core/execplan/ExecutionInfoToken.java 65.52% <0%> (-20.68%) :arrow_down:
.../verdictdb/core/execplan/ExecutableNodeRunner.java 80.27% <0%> (-7.45%) :arrow_down:
.../core/scrambling/FastConvergeScramblingMethod.java 89.59% <0%> (-0.89%) :arrow_down:
...java/org/verdictdb/sqlwriter/SelectQueryToSql.java 78.92% <0%> (+0.55%) :arrow_up:
...org/verdictdb/sqlreader/ScrambleTableReplacer.java 89.59% <0%> (+1.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a965d5...5f2f286. Read the comment docs.