Closed sofiazxy closed 4 years ago
Merging #355 into master will increase coverage by
0.08%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 70.9% 70.97% +0.08%
==========================================
Files 168 168
Lines 11517 11518 +1
Branches 1879 1879
==========================================
+ Hits 8165 8174 +9
+ Misses 2868 2862 -6
+ Partials 484 482 -2
Impacted Files | Coverage Δ | |
---|---|---|
...rg/verdictdb/core/sqlobject/CreateSchemaQuery.java | 81.82% <100%> (+1.82%) |
:arrow_up: |
.../core/scrambling/FastConvergeScramblingMethod.java | 89.6% <0%> (+0.58%) |
:arrow_up: |
...ictdb/core/querying/QueryNodeWithPlaceHolders.java | 88.97% <0%> (+0.69%) |
:arrow_up: |
.../verdictdb/core/execplan/ExecutableNodeRunner.java | 84.9% <0%> (+0.82%) |
:arrow_up: |
...verdictdb/core/querying/ola/InMemoryAggregate.java | 86.24% <0%> (+1.45%) |
:arrow_up: |
...org/verdictdb/connection/CachedDbmsConnection.java | 79.37% <0%> (+1.59%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a29dc0b...8a7c81d. Read the comment docs.
When you try to execute the 2 VerdictDB.sql commands back to back : getting the runtime error: org.verdictdb.exception.VerdictDBDbmsException: Issued the following query: create schema verdictdbtemp org.apache.hadoop.hive.metastore.api.AlreadyExistsException: Database verdictdbtemp already exists;
at org.verdictdb.connection.CachedDbmsConnection.execute(CachedDbmsConnection.java:49) at org.verdictdb.connection.DbmsConnection.execute(DbmsConnection.java:41) at org.verdictdb.coordinator.SelectQueryCoordinator.process(SelectQueryCoordinator.java:128)
This is because: createSchema does not use
IF NOT EXISTS
hence causing the error.Fixed this problem in CreateSchemaQuery() constructor