Closed ZJCSJTU closed 4 years ago
The directory 2.8.0_rc2 includes an executable (compiled on my machine) and one other file to generate new data. But I can rename it a better name. Yes, I wrote gendata. But the sql queries depend on the size of tpch test given by the user. For example, I create database tpchXg for each X-size test, so one can have different-size tests on one machine without removing one before doing another. I can put gendata in tpchtest, so only tpchtest will be needed to run tests.
Compiled C code is machine dependent. Git is for source code not for compiled executable.
Let your script accept an argument, which indicates the root directory of the data folders. Make your script work under the assumption that the data files are stored as follows: (arg directory)
Should I change it to be running test given the existing data (instead of generating data of size given by the user)? Because otherwise those tpch source codes need to be there.
Yes, please let the script run given the existing data.
Merging #358 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
- Coverage 70.9% 70.89% -<.01%
==========================================
Files 168 168
Lines 11517 11517
Branches 1879 1879
==========================================
- Hits 8165 8164 -1
- Misses 2868 2869 +1
Partials 484 484
Impacted Files | Coverage Δ | |
---|---|---|
.../core/scrambling/FastConvergeScramblingMethod.java | 88.73% <0%> (-0.28%) |
:arrow_down: |
...a/org/verdictdb/jdbc41/VerdictStreamResultSet.java | 8.93% <0%> (-0.26%) |
:arrow_down: |
...verdictdb/core/querying/ola/InMemoryAggregate.java | 84.79% <0%> (ø) |
:arrow_up: |
...or/QueryResultAccuracyEstimatorFromDifference.java | 84.16% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a29dc0b...587fa18. Read the comment docs.
I have changed it in that way.
Please do this as well.
"Place sql queries in regular text files. Let your test script load sql from those files and run tests. Then, a single file should be enough for running all tests."
Please remove the directory 2.8.0_rc2 (and files under the directory).
Is gendata the script you wrote?
Place sql queries in regular text files. Let your test script load sql from those files and run tests. Then, a single file should be enough for running all tests.