verdict-project / verdict

Interactive-Speed Analytics: 200x Faster, 200x Fewer Cluster Resources, Approximate Query Processing
http://verdictdb.org
Apache License 2.0
248 stars 66 forks source link

Disable unit tests that use private resources #366

Closed dongyoungy closed 5 years ago

dongyoungy commented 5 years ago

This is an attempt to enable automatic unit tests on external pull requests via CircleCI. This PR: 1) disable unit tests using our private resources via @Ignore annotation 2) comment out git pull on our private resources in the CircleCI configuration

Please note that: 1) Currently our Redshift test instance is down, so CircleCI tests will fail 2) There has been issue with CircleCI image that we use for our jdk7 tests: https://discuss.circleci.com/t/apt-get-update-return-404/29237/8 I have included a temporary fix to it, but we may need to use a different image for a proper fix.

pyongjoo commented 5 years ago

I think it looks good. Let me disable the private repo itself and let you know. In this way, we can fundamentally guarantee no access to the repo.

pyongjoo commented 5 years ago

@dongyoungy Currently, the errors are due to our stopped Redshift cluster. Can you also simply deactivate those unit tests?

pyongjoo commented 5 years ago

@dongyoungy Can you fix the error and merge this to the master? Not urgent, but I would like to base my branch on this.

codecov-io commented 5 years ago

Codecov Report

Merging #366 into master will decrease coverage by 2.26%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage    70.9%   68.64%   -2.25%     
==========================================
  Files         168      168              
  Lines       11517    11517              
  Branches     1879     1879              
==========================================
- Hits         8165     7905     -260     
- Misses       2868     3106     +238     
- Partials      484      506      +22
Impacted Files Coverage Δ
...n/java/org/verdictdb/sqlsyntax/RedshiftSyntax.java 5.56% <0%> (-72.22%) :arrow_down:
...erdictdb/core/scrambling/ScramblingMethodBase.java 57.9% <0%> (-31.57%) :arrow_down:
...rdictdb/core/querying/CreateTableAsSelectNode.java 65.52% <0%> (-24.13%) :arrow_down:
...ava/org/verdictdb/metastore/ScrambleMetaStore.java 67.23% <0%> (-23.88%) :arrow_down:
...ictdb/core/scrambling/UniformScramblingMethod.java 70.32% <0%> (-21.87%) :arrow_down:
...org/verdictdb/sqlreader/ScrambleTableReplacer.java 65.56% <0%> (-16.66%) :arrow_down:
...ain/java/org/verdictdb/commons/StringSplitter.java 82.76% <0%> (-13.79%) :arrow_down:
...va/org/verdictdb/coordinator/ExecutionContext.java 71.67% <0%> (-13.35%) :arrow_down:
src/main/java/org/verdictdb/sqlreader/CondGen.java 66.67% <0%> (-8.77%) :arrow_down:
...in/java/org/verdictdb/sqlreader/ExpressionGen.java 75.31% <0%> (-7.22%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a29dc0b...b044e37. Read the comment docs.

dongyoungy commented 5 years ago

I have further disabled unit tests with redshift and since all unit tests get passed, I am merging this PR.