verdict-project / verdict

Interactive-Speed Analytics: 200x Faster, 200x Fewer Cluster Resources, Approximate Query Processing
http://verdictdb.org
Apache License 2.0
248 stars 66 forks source link

Fix for https://github.com/mozafari/verdictdb/issues/367 #368

Closed pyongjoo closed 5 years ago

pyongjoo commented 5 years ago

Now the predicate is correctly included for calculating original table sizes.

Related issue: https://github.com/mozafari/verdictdb/issues/367

codecov-io commented 5 years ago

Codecov Report

Merging #368 into master will decrease coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #368     +/-   ##
=========================================
- Coverage   68.82%   68.71%   -0.1%     
=========================================
  Files         168      168             
  Lines       11517    11526      +9     
  Branches     1879     1880      +1     
=========================================
- Hits         7925     7919      -6     
- Misses       3090     3104     +14     
- Partials      502      503      +1
Impacted Files Coverage Δ
.../org/verdictdb/core/scrambling/ScramblingPlan.java 100% <ø> (ø) :arrow_up:
.../core/scrambling/FastConvergeScramblingMethod.java 91.91% <ø> (+0.58%) :arrow_up:
...erdictdb/core/scrambling/HashScramblingMethod.java 63.08% <100%> (ø) :arrow_up:
...ictdb/core/scrambling/UniformScramblingMethod.java 70.32% <100%> (ø) :arrow_up:
.../verdictdb/core/scrambling/TableSizeCountNode.java 75% <100%> (-11.66%) :arrow_down:
.../verdictdb/core/execplan/ExecutableNodeRunner.java 83.27% <0%> (-4.89%) :arrow_down:
...a/org/verdictdb/jdbc41/VerdictStreamResultSet.java 8.93% <0%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29fd9a9...17dd7ac. Read the comment docs.