search

verdict-project / verdict

Interactive-Speed Analytics: 200x Faster, 200x Fewer Cluster Resources, Approximate Query Processing
http://verdictdb.org
Apache License 2.0
248 stars 66 forks source link

test external push #369

Closed pyongjoo-external1 closed 5 years ago

pyongjoo-external1 commented 5 years ago

This pull request is simply to test if CircleCI runs.

pyongjoo commented 5 years ago

@dongyoungy To run tests for forked pull requests, it looks like we need to change security setting: https://circleci.com/docs/2.0/oss/#pass-secrets-to-builds-from-forked-pull-requests

The problem is that it may expose the url of our cluster. Do you have any ideas about how to address this?

dongyoungy commented 5 years ago

I did a bit of research and it looks like it seems difficult not to expose sensitive information while accepting PRs from forked repositories with CircleCI: https://stackoverflow.com/questions/55751168/how-to-securely-set-up-continuous-delivery

pyongjoo commented 5 years ago

@dongyoungy Can you check how easy/hard to use presto's docker image for testing? https://hub.docker.com/r/starburstdata/presto/

I don't know what to do about Impala yet.