search

verdie-g / crpg

Multiplayer mod for Mount & Blade II: Bannerlord
https://c-rpg.eu
GNU General Public License v3.0
31 stars 27 forks source link

mod: detach upkeep duration from reward duration #1217

Closed Muparadzi closed 1 year ago

Muparadzi commented 1 year ago

I believe DTV upkeep should be the same as other servers, where it is only influenced by the duration of the round. As the reward system rewards players based on a duration, a workaround for DTV was implemented which also influenced the upkeep. Players' upkeep was influenced by the number of players & the round they are on. This made it difficult for them to understand & plan expenses when playing DTV.

This PR adds a durationUpkeep field to enable DTV upkeep to match other servers. It is likely that rewards will need to be reduced prior to release due to this change.

verdie-g commented 1 year ago

I guess that would work. I'll look for the details later. @namidaka any opinion on this?

namidaka commented 1 year ago

To me duration should always be equal to duration between ticks. Tinkering with it seems hacky and error prone to me. I'd rather have this image So the x1 multiplier always gives the same xp in all modes (except dtv for the moment ) and the you can tweak goldMultiplier and upkeepMultiplier. You could have a mode with very low gold (0.1) and 0 upkeep. Or both set at 0.2

Muparadzi commented 1 year ago

The problem is that we only want the upkeep to be determined by the duration. Whereas gold reward will be defined for each wave, seperate from its duration, otherwise players have no incetive to clear waves quickly.

namidaka commented 1 year ago

The problem is that we only want the upkeep to be determined by the duration. Whereas gold reward will be defined for each wave, seperate from its duration, otherwise players have no incetive to clear waves quickly.

This would be a change in upkeep philosophy as it would make the even breakpoint dependent on team performance. What's the argument for having gold dependent only on wave instead of having xp dependent on wave , and gold dependent on duration?

Muparadzi commented 1 year ago

I think it is fair to reward the players with XP & gold determined by their ability to get through x amount of waves. Having a duration based reward defeats the purpose of clearing those waves, and I think it is important to reward both XP & gold in the same manner for this case.

That said, I'm only looking to charge upkeep based on time rather than scaling together with the reward.

namidaka commented 1 year ago

I think it is fair to reward the players with XP & gold determined by their ability to get through x amount of waves. Having a duration based reward defeats the purpose of clearing those waves, and I think it is important to reward both XP & gold in the same manner for this case.

That said, I'm only looking to charge upkeep based on time rather than scaling together with the reward.

Then for that purpose it's fine.