verdie-g / crpg

Multiplayer mod for Mount & Blade II: Bannerlord
https://c-rpg.eu
GNU General Public License v3.0
31 stars 26 forks source link

Leaving before round end reward skips MMR update for the round #1228

Open jimbojammesi opened 1 year ago

jimbojammesi commented 1 year ago

Describe the bug If a player lands hits or gets hit during a round of battle and then that player leaves the server before the round ends, player MMR is not updated for what happened during that round for the leaver and anyone that hit the leaver. This leads to some unsatisfying game play in which a player can potentially not gain MMR for hitting someone if the person they hit disconnects before the round ends.

To Reproduce Steps to reproduce the behavior:

  1. Play during a round of battle, landing hits on players and/or getting hit by players.
  2. Leave the server before the round ends / rewards are given
  3. MMR does not get properly updated for that round. (for both the leaver and anyone that hit them or was hit by them)

Expected behavior MMR should still be updated as expected for all players based on who they hit and were hit by regardless of who leaves the server before round end.

Context