search

verdigado / sunflower

A WordPress-Theme for the german green party.
GNU General Public License v2.0
36 stars 18 forks source link

Share button fix #737

Closed dersimoezdag closed 3 weeks ago

dersimoezdag commented 1 month ago

Die share-Buttons für WhatsApp und Facebook haben nicht funktioniert. Hiermit gefixed

dersimoezdag commented 4 weeks ago

You fixed the WhatsApp but broke the facebook sharer link. The one and only parameter facebook accepts is the url to the article. So you must not remove get_permalink() as frist string.

Will you fix it or should I?

I didn't remove the get_permalink(), :) I added it, because it was not there before and therefore Facebook didn't work or I misunderstood your comment. But feel free to fix it!

albig commented 4 weeks ago

Sorry, seems I was a little confused. You are right. get_permalink() ist correct. But the second paramter rawurlencode( (string) get_the_title() ), has to be removed. Otherwise you have the title of the post on the title tag and the following "Share on Facebook" is useless because there are only two string placeholders.

dersimoezdag commented 4 weeks ago

Ah! I see! You are right! Thank you for your feedback! :)