search

verekia / js-stack-from-scratch

🛠️⚡ Step-by-step tutorial to build a modern JavaScript stack.
MIT License
20.05k stars 1.99k forks source link

Missing bundle.js in Heroku #186

Closed denezra closed 7 years ago

denezra commented 7 years ago

Type of issue: Missing File

Chapter: 09 - Travis, Coveralls, Heroku

Upon checking my work on Heroku I'm missing a file called bundle js. Looking to close to it seems we added a rule on .gitignore /dist/, so every time I upload my work its missing the bundle.js

Screenshot of Missing file: https://www.dropbox.com/s/344ms5dewo4rx9o/Screenshot%202017-03-29%2006.24.04.png?dl=0

Link: https://your-project-staging-den.herokuapp.com/

verekia commented 7 years ago

You should not have the bundle in your Git. Heroku should build the bundle at every deployment.

Maybe you skipped the instruction about the heroku-postbuild task?

denezra commented 7 years ago

Hi and thanks for replying.

Just added that heroku-postbuild in script in package.json. But will take a look a again if I definitely miss some instruction there.

(Sorry first time to code)

verekia commented 7 years ago

Awh man, this tutorial is way too advanced if that's your first time coding my friend. You should focus on the basics, and JS is probably not a great language to start with. Python would be my recommendation.

denezra commented 7 years ago

Oh I see but my friend recommend this to me since its easy to understand and learn.

verekia commented 7 years ago

Well I'm glad it is easy to understand and learn, but like the introduction says, this tutorial is made to learn how to wire some tools together. These tools are absolutely overkill if you are just beginning.

I'm going to close this issue for now :)