dev:wds error on chapter 4

verekia / js-stack-from-scratch

🛠️⚡ Step-by-step tutorial to build a modern JavaScript stack.

MIT License

20.05k stars 1.99k forks source link

dev:wds error on chapter 4 #198

Open pzac opened 7 years ago

pzac commented 7 years ago

Type of issue: (feature suggestion, bug?)

Bug

Chapter:

4 - HMR

If it's a bug:

yarn dev:wds was triggering an error

url.js:576
    host = auth + (this.hostname.indexOf(':') === -1 ?
                                 ^
TypeError: this.hostname.indexOf is not a function

The error persisted until I added the host flag to the dev:wds script in package.json:

"dev:wds": "webpack-dev-server --progress --host 0.0.0.0",

penggy commented 6 years ago

seems webpack-dev-server's problem since webpack-dev-server@2.8.2

infantito commented 6 years ago

Why? :c