verekia / js-stack-from-scratch

🛠️⚡ Step-by-step tutorial to build a modern JavaScript stack.
MIT License
20.05k stars 1.99k forks source link

Add created footer to App, improve app name #208

Closed iamandrewluca closed 6 years ago

iamandrewluca commented 7 years ago

Type of issue: suggestion

Chapter: 8

If it's a suggestion:

Import created footer in src/shared/app.jsx

import Footer from './component/footer'

Add it after </Switch> statement or in other desired place.

<!-- ... -->
  <Route path={HELLO_ASYNC_PAGE_ROUTE} render={() => <HelloAsyncPage />} />
  <Route component={NotFoundPage} />
</Switch>
<Footer />

Also because we have {APP_NAME} in nav bar, remove

<h1>{APP_NAME}</h1>

in src/shared/app.jsx right before <Helmet titleTemplate... to make app look better!

image