search

verekia / js-stack-from-scratch

🛠️⚡ Step-by-step tutorial to build a modern JavaScript stack.
MIT License
20.09k stars 1.99k forks source link

Yarn test fails due to flow error #244

Closed watadarkstar closed 7 years ago

watadarkstar commented 7 years ago

EDIT: This should no longer be an issue with the latest version of these packages, but if you have this problem here is the fix.

Going through the guide and I got a flow error running yarn test at the part where one is required to add flow. See: https://github.com/verekia/js-stack-from-scratch/issues/221

The solution is to add the following to your .flowconfig :

[ignore]
.*/node_modules/eslint-plugin-jsx-a11y/*

I propose to add this to the guide so others won't have this issue. Like these people: https://github.com/verekia/js-stack-from-scratch/issues/237 and https://github.com/verekia/js-stack-from-scratch/issues/221

IsoLinearCHiP commented 7 years ago

Hi. Just wanted to report this issue myself. I encountered the same problem while following along. After some trial and error with the ignore pattern I eventually arrived at the same result.

correction: I used the string: .*/node_modules/eslint-plugin-jsx-a11y/.* (notice the trailing extra .) assuming its a regex. I do not know which is technically correct.

+1 for including it in the (very helpfull :) ) guide.

watadarkstar commented 7 years ago

@verekia can you review and merge this :)

verekia commented 7 years ago

This is not an issue anymore with the recent versions of these packages, so we should probably discard the PR :) The whole tutorial needs a major update though.

watadarkstar commented 7 years ago

@verekia Okay closes this PR 👍