search

veres-one / did-veres-one

A Decentralized Identifier utility library for Veres One
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Use ursa#master. #4

Closed mattcollier closed 6 years ago

mattcollier commented 6 years ago

Ursa 0.9.4 (the current release) does not build on node 10.x. This has been fixed on master but it is unclear when we will see a release.

https://github.com/JoshKaufman/ursa/issues/172

davidlehn commented 6 years ago

Might be better to point to a specific commit to avoid pulling in random development commits to their master branch. Otherwise this looks fine.

mattcollier commented 6 years ago

@davidlehn good suggestion.

Also, I did some research around this time about other native libs we might use for RSA key generation. There are a number of simple wrappers around OpenSSL for this one specific function however none of them are very popular. Here's just a couple examples:

  1. https://github.com/LinusU/node-generate-rsa-keypair
  2. https://github.com/sunjith/node-rsa-keypair