veres-one / did-veres-one

A Decentralized Identifier utility library for Veres One
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

attachInvocationProof takes both a key and a signer #70

Open aljones15 opened 3 years ago

aljones15 commented 3 years ago

https://github.com/veres-one/did-veres-one/blob/fbd9fc8fee0636c8e7722afa77b75f267786997b/lib/attachProof.js#L106-L131

Questions:

  1. Why do we need both a signer and a key?
  2. Can we just pass in one of them?

Answer:

  1. I believe we accommodate passing in either a key or signer. We might want to make sure you're only passing in one with a warning.