search

veres-one / did-veres-one

A Decentralized Identifier utility library for Veres One
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Add v1.generate({seed}) feature, to match did:key driver #74

Closed dmitrizagidulin closed 2 years ago

dmitrizagidulin commented 2 years ago

Add the ability to generate a new Veres One DID from a seed, to match did:key driver. (Just like with did:key, if a seed param is present, use it to generate a capabilityInvocation key.)

Note: Make the PR off of https://github.com/veres-one/did-veres-one/pull/60 / v14.x branch.

msporny commented 2 years ago

Where do we use this feature? Why do we need it?

dmitrizagidulin commented 2 years ago

@msporny - we use this in did-io, and were using it in our admin CLI tool.

msporny commented 2 years ago

@msporny - we use this in did-io, and were using it in our admin CLI tool.

Yes, but why? What's the use case? Someone wants to use an external random number generator for a seed? Someone wants to physically imprint the seed on titanium plates?

aljones15 commented 2 years ago

just a small note, this makes did-veres-one have the same generate interface as did-method-key. This helps as right now if you want your app to be cross-compatible with did-method-key and did-veres-one you have to generate did-method-key from a 32-byte Uint8Array and then did-veres-one from an Ed25519Key. Basically, did-veres-one requires an extra step.

aljones15 commented 2 years ago

I believe this can be closed as this was is now a feature in v14.x https://github.com/veres-one/did-veres-one/pull/75

JSAssassin commented 2 years ago

Closing, implemented.