search

veres-one / veres-one-validator

A ledger validator that accepts either signatures or proof of work
Other
3 stars 0 forks source link

Use witness selection method #39

Closed aljones15 closed 3 years ago

aljones15 commented 3 years ago

THIS IS NOT COMPLETE. This is a start on updating validators to support witness selection.

p.s. this assumes that veres-one should be running in test mode when testing i.e. validators should expect the prefix did:v1:test:nym and not did:v1:nym.

codecov-commenter commented 3 years ago

Codecov Report

Merging #39 (82acd1d) into add-string-length-validators (8360721) will decrease coverage by 6.58%. The diff coverage is 100.00%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           add-string-length-validators      #39      +/-   ##
================================================================
- Coverage                         96.58%   90.00%   -6.59%     
================================================================
  Files                                15       15              
  Lines                               381      370      -11     
================================================================
- Hits                                368      333      -35     
- Misses                               13       37      +24
Impacted Files Coverage Δ
lib/index.js 97.61% <100.00%> (ø)
lib/validators/updateWebLedgerRecord.js 96.07% <100.00%> (-3.93%) :arrow_down:
schemas/did-uuid.js 100.00% <100.00%> (ø)
schemas/did.js 100.00% <100.00%> (ø)
schemas/didReference.js 100.00% <100.00%> (ø)
schemas/veres-one-validator.js 100.00% <100.00%> (ø)
lib/validators/helpers.js 74.00% <0.00%> (-20.00%) :arrow_down:
lib/validators/createWebLedgerRecord.js 86.04% <0.00%> (-4.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8360721...82acd1d. Read the comment docs.

msporny commented 3 years ago

Everything has been upgraded and tests work now, merging down to string length validators branch.