search

verful / adonis-notifications

Handle notifications on your AdonisJS applications
MIT License
66 stars 8 forks source link

V6 support #50

Open HasanAshab opened 7 months ago

HasanAshab commented 7 months ago

When the pkg would be migrated to V6?

If you need help I can contribute.. :)

arthur-er commented 7 months ago

No ETA, as I'm not using v6 yet.

HasanAshab commented 7 months ago

Thanks for the update. Since there's no ETA for migrating to v6 yet and you're not currently using it, would it be possible for me to assist in making the necessary changes for v6 compatibility? Once done, we could work on making a new release together. Let me know if you're open to this collaboration!

maukoese commented 7 months ago

I'm willing to help with this, as we have a couple of projects using v6 and really need our important packages updated to work with 6.

Especially this one and the permissions one

arthur-er commented 7 months ago

V6 skeleton started on https://github.com/verful/adonis-notifications/tree/v6, I don't have much time to work on v6 support yet so I will let it up to you guys

maukoese commented 5 months ago

Hello @arthur-er, @HasanAshab

I got a version of this working with v6, it's actually in production. See https://github.com/osenco/adonis-notifications

I say version because I removed all the tests and wasn't able to export the default Notification helper so that we can do 

Notification.send()

Without this I can't implement custom channels like sms and fcm.

Any asistance will be hightly appreciated.

@arthur-er perhaps we can fix these issues on my repo then once it all works we make a PR back to this one?

adrianNEMO commented 5 months ago

Hi @maukoese have you tried the latest version of my fork? https://github.com/nemoengineering/adonis-notifications. There is a ready to use npm package in the github packages repo.

@arthur-er if you want to merge this in im happy to give it to this repo.

maukoese commented 5 months ago

@adrianNEMO Did you publish to npm? I had forked yours because i Needed to implement the project urgently.

I'd seem you haven't published to npm yet.

Screenshot 2024-04-10 at 18 19 26
maukoese commented 5 months ago

@arthur-er @HasanAshab please consider merging this

simoneNEMO commented 5 months ago

@maukoese we (I work with @adrianNEMO ) have pushed to GitHub packages (https://github.com/nemoengineering/adonis-notifications/pkgs/npm/notifications) since it is more straight-forward for us.

I agree the ideal would be this changes to be folded back into this very repo or at some point become an official AdonisJS package (as many frameworks like Laravel and Rails offer first party notification systems)