The comments here aren't necessarily blocking, but it would be good to implement some of these suggestions:
[x] The pyproject.toml file:
[x] The documentation URL points to the documentation page of Poetry
[x] There should be some classifiers listed to help identify the package based on its contents (see: https://pypi.org/classifiers/)
[x] Don't bother trying to expand support for Python3.8 (currently end-of-life)
[ ] #435
[x] Packaged data is kind of enormous: The PyPI wheel/sources are around 13 MB when archive is inflated, with the majority of that space being used by a Shapefile. Is there a way of fetching a subset of that data remotely, maybe? To help bring down the space used, the wheel should only package the data needed to run (not test/demonstrate) the library.
[x] .readthedocs.yml - The os could be updated to ubuntu-22.04
[x] Linting
[x] The repository has a disabled black action. Have you considered using pre-commit or pre-commit.ci?
The comments here aren't necessarily blocking, but it would be good to implement some of these suggestions:
pyproject.tomlfile:documentationURL points to the documentation page ofPoetry.readthedocs.yml- Theoscould be updated toubuntu-22.04blackaction. Have you considered using pre-commit or pre-commit.ci?pyproject.tomlfile could be used to set the linting and style configuration for the code base (usingflake8orruff). (example from a project I maintain calledxclim: https://github.com/Ouranosinc/xclim/blob/2d981abc8291645da235c52479162953ef2ab6d6/pyproject.toml#L215)pyproject.tomlfile could be cleaned up a bit (https://github.com/macisamuele/language-formatters-pre-commit-hooks)Context: https://github.com/openjournals/joss-reviews/issues/5916