search

vergauwenthomas / MetObs_toolkit

A toolkit for using non-traditional meteorological observations
https://vergauwenthomas.github.io/MetObs_toolkit/
MIT License
12 stars 4 forks source link

[JOSS] Paper minor corrections #452

Closed vergauwenthomas closed 6 months ago

vergauwenthomas commented 6 months ago

Minor corrections suggestions by @ashwinvis:

“48 ... data for analysis by making intensive use of the pandas (The pandas development team, 2023) and geopandas (Jordahl et al., 2020) functionalities” (Vergauwen et al., 2024, p. 2) (pdf)

*use of the functionalities from pandas (..) and geopandas (..) libraries.

“52 data is imported into the Toolkit Dataset” (Vergauwen et al., 2024, p. 3) (pdf)

into a Toolkit Dataset class instance

“61 Modeldata” (Vergauwen et al., 2024, p. 3) (pdf)

Modeldata class instance

Finally could you make the typography consistent between

Toolkit Dataset Toolkit Modeldata Toolkit-Analysis ?

vergauwenthomas commented 6 months ago

Ref: https://github.com/openjournals/joss-reviews/issues/5916

amberJ99 commented 6 months ago

Can you add my FWO number to the publication? My number is 11PBN24N.

vergauwenthomas commented 6 months ago

Refer to the documentation (version) for more details:

Further reading and citations needed here Since MetObs-Toolkit implements quite a few methods, it would be important to link to other sources which may describe them in detail. If you think that these methods might be subject to change, it might be sufficient to cite the references in the online documentation and link this software paper to the documentation instead. See how scikit-image does it.

“55 to examine data types, irregular timestamps, max-min thresholds, repetitions criteria, spike tests, allowed variation in time windows and spatial tests” (Vergauwen et al., 2024, p. 3) (pdf)

These, IMHO, are quite involved methods. What are the formal basis behind these QC methods or are they based on intuition? Some reuses TITAN (titanlib) while the rest are implemented from the scratch (which means citing TITAN alone will not be sufficient). .

“59 ... gap filling is applied by using interpolation methods” (Vergauwen et al., 2024, p. 3) (pdf)

Gap filling and bias correction is another involved topic. What is the basis behind the methods used? Further reading and citations needed here.

vergauwenthomas commented 6 months ago

Finally could you make the typography consistent between

Toolkit Dataset Toolkit Modeldata Toolkit-Analysis ?

When referring to a class of the toolkit i used recursive.