search

vericast / conda-mirror

Mirror upstream conda channels
BSD 3-Clause "New" or "Revised" License
72 stars 60 forks source link

Handle EOFError when reading tar files. #58

Closed dmkent closed 7 years ago

dmkent commented 7 years ago

Deal with exception from tar file.

Relates issue #57.

pep8speaks commented 7 years ago

Hello @dmkent! Thanks for submitting the PR.

Line 430:80: E501 line too long (81 > 79 characters) Line 529:80: E501 line too long (81 > 79 characters) Line 530:80: E501 line too long (91 > 79 characters) Line 615:80: E501 line too long (91 > 79 characters)

codecov[bot] commented 7 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits          229      229           
  Misses          8        8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.58% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5601f0...26b6013. Read the comment docs.

ericdill commented 7 years ago

Ultimately the same issue as #56 . Thanks for the PR @dmkent !

Closes #56 Closes #57

ericdill commented 7 years ago

@dmkent the 0.7.3 release (with your bugfix) is available on pypi (pip install --upgrade conda-mirror) and will be available via conda-forge soon-ish (https://github.com/conda-forge/conda-mirror-feedstock/pull/3)