Closed ericdill closed 7 years ago
Hello @ericdill! Thanks for updating the PR.
conda_mirror/conda_mirror.py
, following are the PEP8 issues :Line 178:80: E501 line too long (80 > 79 characters) Line 448:80: E501 line too long (81 > 79 characters) Line 551:80: E501 line too long (81 > 79 characters) Line 552:80: E501 line too long (91 > 79 characters) Line 645:80: E501 line too long (89 > 79 characters) Line 658:80: E501 line too long (95 > 79 characters)
test/test_conda_mirror.py
, following are the PEP8 issues :Line 134:80: E501 line too long (85 > 79 characters) Line 145:80: E501 line too long (97 > 79 characters) Line 146:80: E501 line too long (82 > 79 characters) Line 147:80: E501 line too long (84 > 79 characters) Line 159:80: E501 line too long (86 > 79 characters) Line 160:80: E501 line too long (81 > 79 characters) Line 161:80: E501 line too long (82 > 79 characters) Line 162:80: E501 line too long (84 > 79 characters) Line 177:80: E501 line too long (98 > 79 characters)
Merging #59 into master will increase coverage by
0.26%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 96.62% 96.88% +0.26%
==========================================
Files 2 2
Lines 237 257 +20
==========================================
+ Hits 229 249 +20
Misses 8 8
Impacted Files | Coverage Δ | |
---|---|---|
conda_mirror/conda_mirror.py | 96.85% <100%> (+0.26%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3e7bda1...e37d364. Read the comment docs.
Other than the one very minor nit, it looks fine. :shipit:
Thanks @parente
Pretty simple addition:
--dry-run
. This exits after figuring out what local packages are blacklisted and need to be removed.Closes #39