vericast / conda-mirror

Mirror upstream conda channels
BSD 3-Clause "New" or "Revised" License
72 stars 60 forks source link

Space check #70

Closed magnuhho closed 6 years ago

magnuhho commented 6 years ago

By default conda-mirror will continue pulling files until it either succeeds or dies from some sort of error. This change aborts downloads with a logger.error when a threshold is reached.

magnuhho commented 6 years ago

Whoops. Didn't see the work done and the comments to #64.

parente commented 6 years ago

@magnuhho Thanks for the series of PRs. I need to get travis working again properly for the repo (it changed orgs) and will give them a look-see.

magnuhho commented 6 years ago

added changes to

codecov-io commented 6 years ago

Codecov Report

Merging #70 into master will decrease coverage by 1.19%. The diff coverage is 64.28%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #70     +/-   ##
========================================
- Coverage   93.89%   92.7%   -1.2%     
========================================
  Files           2       2             
  Lines         262     274     +12     
========================================
+ Hits          246     254      +8     
- Misses         16      20      +4
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 92.61% <64.28%> (-1.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96bad91...a29a55d. Read the comment docs.

parente commented 6 years ago

Thanks for working through this @magnuhho. It looks reasonable now. We'll probably want to add a test for it in the future, but let's get this merged for now. 🎉