Fix lack of pagination support for attachments

vericast / nbconflux

nbconflux converts Jupyter Notebooks to Atlassian Confluence pages

BSD 3-Clause "New" or "Revised" License

117 stars 33 forks source link

Fix lack of pagination support for attachments #8

Closed parente closed 6 years ago

parente commented 6 years ago

Respect the presence of ._links.next in attachment responses
Add lots-of-plots.ipynb manual test notebook
Move test notebooks into a tests/notebooks subdir

QA'ed against confluence server and confluence cloud APIs. Fixes #6. /cc @samhendley

samhendley commented 6 years ago

LGTM. This will keep accumulating attachments with each version, does that cleared out if we use normal confulence deleting of a page/versions?

parente commented 6 years ago

AFAIK, attachments get "cleared" when the page gets deleted or when you manually go in and delete them. I don't know of any other history management options in Confluence.