search

vericast / spylon

Utilities to work with Scala/Java code with py4j
https://maxpoint.github.io/spylon/
BSD 3-Clause "New" or "Revised" License
40 stars 16 forks source link

Expose various oddities in spylon and various other updates #35

Closed ericdill closed 7 years ago

ericdill commented 7 years ago

Fun. This seems to have exposed a potential bug in setting environmental variables? I'm reallllllly hoping this is just a pytest thing.

Well this has turned in to a general "let's have a look at this library and poke at things that could use poking"

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5933615). Click here to learn what that means. The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   65.55%           
=========================================
  Files             ?       15           
  Lines             ?     1077           
  Branches          ?        0           
=========================================
  Hits              ?      706           
  Misses            ?      371           
  Partials          ?        0
Impacted Files Coverage Δ
tests/test_spark_docker.py 96.82% <100%> (ø)
spylon/spark/launcher.py 67.47% <100%> (ø)
tests/test_spark_launcher.py 100% <100%> (ø)
spylon/spark/yarn_launcher.py 43.79% <5.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5933615...e5f99dc. Read the comment docs.

parente commented 7 years ago

Rebased on master to resolve merge conflicts first.

parente commented 7 years ago

Addressed code review comments.

ericdill commented 7 years ago

Thanks for taking this across the finish line