search

verifalia / verifalia-ruby-sdk

Verifalia Ruby SDK
MIT License
7 stars 6 forks source link

Validation jobs incorrectly marked as completed #16

Closed verifalia closed 1 year ago

verifalia commented 7 years ago

The EmailValidations class incorrectly marks a validation job as completed if the noOfCompletedEntries is equal to noOfTotalEntries:

https://github.com/verifalia/verifalia-ruby-sdk/blob/master/lib/rest/email_validations.rb#L88

This behavior is wrong, as the API returns the completion status for a validation job in a RESTful fashion: in particular, the HTTP 202 (Accepted) status code means the API consumer should reissue the request later (see http://verifalia.com/developers/email-validations#getting-status). Apart from compliance to the API specification, this behavior can cause issues if the API consumer expects to actually find its validation results whenever the SDK marks a validation job as completed.

verifalia commented 1 year ago

This has been fixed with version 2.0.0 of the SDK.