search

verigak / progress

Easy to use progress bars for Python
ISC License
1.41k stars 179 forks source link

Update README.rst #35

Closed clime closed 7 years ago

clime commented 8 years ago

Updated description for avg and eta properties.

praiskup commented 8 years ago

Is it rather possible to get back the old API, by some arithmetic?

Changing semantics of api is unfortunate -- that requires all consumers will have to change the code.

verigak commented 8 years ago

@praiskup Yes, the whole moving average thing has caused more problems than it solved. At this point the safest option is to go back to the old semantics, as this is the one that is in PyPI and most people are using.

praiskup commented 8 years ago

@verigak thanks, makes sense. OTOH, I still would be interested in getting the patches from #24 into your code, it fixes the moving average calculation (and makes it a lot faster). Moving to simple average sounds like a step back (from "user's convenience" POV).

verigak commented 8 years ago

Yes you are right, but I think I would prefer to keep the algorithm simple and instead provide a way to easily to plug your own algorithm. What do you think about this approach?

praiskup commented 8 years ago

I like the idea of "having the altorithm configurable", so if that was possible?

But I wouldn't force users to implement the algorithm themselves, I still think the proposed moving average calculation is safe :).

verigak commented 7 years ago

Thanks, I ended up keeping the initial semantics